symfony-cmf / menu-bundle

Extends the KnpMenuBundle to work with PHPCR ODM
https://cmf.symfony.com
32 stars 48 forks source link

investigate test failure in MenuAdminTest::testMenuEdit #127

Closed dbu closed 11 years ago

dbu commented 11 years ago

see the travis tests of the bundle https://travis-ci.org/symfony-cmf/MenuBundle/jobs/10886858

note the test is now marked as skipped in master

lsmith77 commented 11 years ago

so this is caused by the fact that the first tab in the admin edit form loads the tree widget (btw only when editing .. not when creating which is why only edit fails).

i added asset:install to the testing scripts (see below), but this still doesn't fix the test. but then at least i could load http://localhost:8000/app_test.php/admin/cmf/menu/menu/test/menus/test-menu/edit .. however the ajax requests to load the actual tree fail with the same old error message but i think the issue is that some broken html gets generated:

http://localhost:8000/app_test.php/admin/cmf/menu/menu/test/menus/test-menu/__%3Cscript%20type=%22text/javascript%22%20src=%22/bundles/fosjsrouting/js/router.js%22%3E%3C/script%3E_%3Cscript%20type=%22text/javascript%22%20src=%22/app_test.php/_cmf_tree/phpcr_odm_tree/children?_locale=en&root=%2Ftest%2Fmenus
diff --git a/bin/travis/doctrine_orm.sh b/bin/travis/doctrine_orm.sh
index 7abdacd..dd6f348 100755
--- a/bin/travis/doctrine_orm.sh
+++ b/bin/travis/doctrine_orm.sh
@@ -2,8 +2,10 @@

 DIR_NAME=`dirname $0`
 CONSOLE_DIR=$DIR_NAME"/.."
+WEB_DIR=$DIR_NAME"/../../resources/web"

 # composer install --dev
 php $CONSOLE_DIR"/console" doctrine:database:create --env=orm
 php $CONSOLE_DIR"/console" doctrine:schema:create --env=orm
 php $CONSOLE_DIR"/console" doctrine:phpcr:repository:init
+php $CONSOLE_DIR"/console" assets:install $WEB_DIR
diff --git a/bin/travis/phpcr_odm_doctrine_dbal.sh b/bin/travis/phpcr_odm_doctrine_dbal.sh
index 38e25ed..7244b06 100755
--- a/bin/travis/phpcr_odm_doctrine_dbal.sh
+++ b/bin/travis/phpcr_odm_doctrine_dbal.sh
@@ -2,7 +2,9 @@

 DIR_NAME=`dirname $0`
 CONSOLE_DIR=$DIR_NAME"/.."
+WEB_DIR=$DIR_NAME"/../../resources/web"

 # composer install --dev
 php $CONSOLE_DIR"/console" doctrine:phpcr:init:dbal --drop
 php $CONSOLE_DIR"/console" doctrine:phpcr:repository:init
+php $CONSOLE_DIR"/console" assets:install $WEB_DIR

/cc @dantleech

lsmith77 commented 11 years ago

issues was fixed by https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/commit/e0f2977d0aa665ddb93e577e42de51280b0be933