symfony-cmf / menu-bundle

Extends the KnpMenuBundle to work with PHPCR ODM
https://cmf.symfony.com
32 stars 48 forks source link

Switch to KnpMenuBundle 2.0 #202

Closed benglass closed 9 years ago

benglass commented 10 years ago

2.0 has now been released https://github.com/KnpLabs/KnpMenu/tree/v2.0.1

Need to resolve

82

83

3

19

lsmith77 commented 10 years ago

oh sweet! it would be huge if we could adopt that for CmfMenuBundle .. I guess we would then also need to bump our version to 2.0

/cc @dbu

lsmith77 commented 10 years ago

3 does not yet seem to be covered but will be in 2.1 -> https://github.com/KnpLabs/KnpMenu/pull/161

dbu commented 10 years ago

i guess this could be too tight for our 1.2 release, unless somebody has a lot of time this week.

@dawehner proposed to have a look at the drupal 8 code which can handle breadcrumb independently from menu: https://twitter.com/da_wehner/status/498936596486701056 - so this could be another course of action: if the drupal code fits what we need, help david to build a clean standalone library out of that code.

rande commented 10 years ago

The 2.3 release to Sonata Admin Bundle will require KnpMenu 2.0. But as it is use for a specific menu, I guess we can rework the AdminBundle integration.

Let me know what you think

lsmith77 commented 10 years ago

It would be great to find a workaround.

lsmith77 commented 10 years ago

in the mean time .. I will start a 2.0 branch for CmfMenuBundle .. though I must admit I do not know the bundle in much detail .. but lets get it started ASAP.

lsmith77 commented 10 years ago

FYI @rande confirmed that SonataAdmin 2.3 will work with KnpMenu 1 and 2 after all

rande commented 10 years ago

It was wrong until https://github.com/sonata-project/SonataAdminBundle/commit/cfad91f5743707bf27fed2e438a63fa7adfd6b39 ;)

Now it is ok

lsmith77 commented 10 years ago

when are you going to tag a version with all of this?

rande commented 10 years ago

Missed this feature: tab/group layout. (Real life events https://github.com/sonata-project/SonataAdminBundle/issues/1723#issuecomment-51804865)