symfony-cmf / resource-bundle

Resource Location for CMF documents based on Puli
https://cmf.symfony.com
5 stars 7 forks source link

Added doctirne phpcr odm description enhancer #34

Closed dantleech closed 8 years ago

dantleech commented 8 years ago

This PR adds support for the Doctrine PHPCR-ODM enhancer and will also integrate the Sylius / Sonata enhancers in order that they can use the CHILD_TYPES descriptor (if) previously set.

dantleech commented 8 years ago

Updated. Enhancers can now have a priority (required in the case of the Sylius enhancer which adds fields based on the CHILDREN_TYPES descriptor from the PHPCR-ODM enahncer).

Also removed "automatically remove inactive enhancers" feature which we agreed was not needed while the enhancers are private.

/cc @WouterJ @dbu

dbu commented 8 years ago

looks good to me. the tests run into a sonata change somehow, not seeing a service anymore.

dantleech commented 8 years ago

This is GTM. Failing test on PHP7 due to unrelated problem: https://github.com/symfony-cmf/testing/pull/127/files

dbu commented 8 years ago

nice!