search

symfony-cmf / routing-auto-bundle

Adding automatic route generating on top of the symfony cmf routing
https://cmf.symfony.com
14 stars 29 forks source link

allow setting of attributes on the generated routes #144

Closed briancappello closed 9 years ago

briancappello commented 9 years ago

depends on https://github.com/symfony-cmf/RoutingAuto/pull/21 addresses #139

dantleech commented 9 years ago

Hi, thanks alot for taking the time to do this. I don't like blindly calling setters on unknown objects, we could have added some validation - but then I think letting people call arbitrary methods on objects is a good way to introduce bugs (e.g. you could call setPattern) and also adds more questions - e.g. should we allow token substitution on the attribute values?

But I see the use case, so I did :

https://github.com/symfony-cmf/RoutingAuto/pull/22

Which I also decided would be a bad idea (basically huge change, for questionable benefit - read the above PR description). I suggest instead that we implement an EventDispatcher which would allow people to set things as they want.

I am closing this, lets continue the discussion in the above issue.