symfony-cmf / routing-auto-bundle

Adding automatic route generating on top of the symfony cmf routing
https://cmf.symfony.com
14 stars 29 forks source link

Convert non-managed intermediate nodes into AutoRoute documents #168

Closed mmenozzi closed 9 years ago

mmenozzi commented 9 years ago

This is a backport on 1.0 branch of the feature/bugfix for the Generic intermediates nodes which now will be converted in AutoRoute if needed.

dantleech commented 9 years ago

@WouterJ @dbu seems to be failing because of the deprecation notice, do we need to add SYMFONY_DEPRECATIONS_HELPER=weak to the travis environment?

wouterj commented 9 years ago

@dantleech no, we can fix the method calls (don't have to be done in this PR though).

mmenozzi commented 9 years ago

@dantleech can we go for the 1.0.2 ?

dantleech commented 9 years ago

@mmenozzi can you add the SYMFONY_DEPRECATIONS_HELPER=weak to the travis.yml file in this PR, e.g. https://github.com/symfony-cmf/RoutingAutoBundle/blob/master/.travis.yml#L18

Then the tests should be green and this PR will be mergable.

wouterj commented 9 years ago

@dantleech just fix the calls to use getParentDocument instead of getParent.

dantleech commented 9 years ago

@mmenozzi ^^ that :)

mmenozzi commented 9 years ago

@dantleech @WouterJ done! :)

wouterj commented 9 years ago

:+1:

dantleech commented 9 years ago

Have tagged 1.0.2.