search

symfony-cmf / routing-auto-bundle

Adding automatic route generating on top of the symfony cmf routing
https://cmf.symfony.com
14 stars 29 forks source link

adjust to removed extra argument from AdapterInterface #208

Closed dbu closed 7 years ago

dbu commented 7 years ago

adjust to https://github.com/symfony-cmf/routing-auto/pull/100

restart build once the routing-auto PR is merged and RC3 tagged.

ElectricMaxxx commented 7 years ago

now it is consistently broken :-)

dbu commented 7 years ago

fixed the mistakes in the PR, now we only have those left that happened on master before too.

ElectricMaxxx commented 7 years ago

I restarted the build, hoping it was the doctrine-odm. But the errors are still there @dantleech @wouterj any chance to fix that?

ElectricMaxxx commented 7 years ago

@dbu @dantleech I think i found the problem, but without knowing why:

there was a change for jms/metadata from 1.5.* to ^1.5, which also allows 1.6, on routing-auto. I get to that issue, as i tried to require symfony-cmf/routing-auto:2.0.0-RC1, cause i whanted to see the former behavior. That said i had to fix jms/metadata to 1.5.0. And then ... The tests are green.

So we should revert the jms/metadata dependency change on routing-auto, release and this will be green, or somebody knows what the change in serializer had been?

ElectricMaxxx commented 7 years ago

I should work with the branch first, for next time. But i got the tests running with 1.5.0. So 1.5.1 is definetly broken as this is the version on our tests.

ElectricMaxxx commented 7 years ago

I have no idea anymore :-( i had it working and running localy with jms/metada:1.5.0 and symfony-cmf/routing-auto:2.0.0-RC1 but ther is no other change on RC2 then the jms change.

ElectricMaxxx commented 7 years ago

i work on in https://github.com/symfony-cmf/routing-auto-bundle/pull/210