Closed juanjomb closed 3 years ago
we did that in #122
it seems there is no test coverage for the class :-( i guess we have to deprecate version 2.1.1 and do a fixed 2.2.0
the change you propose will break with jms 1.x . i think the correct solution is to only allow jms ^2.1
in composer.json - can you edit that file accordingly in this MR please?
we did that in #122
it seems there is no test coverage for the class :-( i guess we have to deprecate version 2.1.1 and do a fixed 2.2.0
the change you propose will break with jms 1.x . i think the correct solution is to only allow jms
^2.1
in composer.json - can you edit that file accordingly in this MR please?
Sure, done.
Thanks!
i reverted the composer change in #124 and released a patch version. now i solve the merge conflict in #127 , will merge once it is green.
i reverted the composer change in #124 and released a patch version. now i solve the merge conflict in #127 , will merge once it is green.
Ok, closing this then.
Thank you!
released as 2.2.0. thanks for the fix!
The purpose of this PR is to provide compatibility with jms/metadata type hinting as version requirement has been upgraded recently.