search

symfony-cmf / routing-auto

RoutingAuto component
https://cmf.symfony.com
Other
6 stars 11 forks source link

Fix type hinting from jms/metadata #123

Closed juanjomb closed 3 years ago

juanjomb commented 3 years ago

The purpose of this PR is to provide compatibility with jms/metadata type hinting as version requirement has been upgraded recently.

dbu commented 3 years ago

we did that in #122

it seems there is no test coverage for the class :-( i guess we have to deprecate version 2.1.1 and do a fixed 2.2.0

the change you propose will break with jms 1.x . i think the correct solution is to only allow jms ^2.1 in composer.json - can you edit that file accordingly in this MR please?

juanjomb commented 3 years ago

we did that in #122

it seems there is no test coverage for the class :-( i guess we have to deprecate version 2.1.1 and do a fixed 2.2.0

the change you propose will break with jms 1.x . i think the correct solution is to only allow jms ^2.1 in composer.json - can you edit that file accordingly in this MR please?

Sure, done.

Thanks!

dbu commented 3 years ago

i reverted the composer change in #124 and released a patch version. now i solve the merge conflict in #127 , will merge once it is green.

juanjomb commented 3 years ago

i reverted the composer change in #124 and released a patch version. now i solve the merge conflict in #127 , will merge once it is green.

Ok, closing this then.

Thank you!

dbu commented 3 years ago

released as 2.2.0. thanks for the fix!