search

symfony-cmf / routing-auto

RoutingAuto component
https://cmf.symfony.com
Other
6 stars 11 forks source link

add build matrix, requiring all symfony 2.x versions to succeed #15

Closed dbu closed 10 years ago

dbu commented 10 years ago

@dantleech this error seems to be existing already. can you help me fix this?

dantleech commented 10 years ago

Strange, it looks like the test is fine but we are comparing the expected exception with too many escape slashes. Will have a look tonight //cc @WouterJ

lsmith77 commented 10 years ago

yeah .. strange that it passed once but the issue seems to have been introduced recently: https://github.com/symfony-cmf/RoutingAuto/commit/66998e7ddb0de1eb516c1d3b215c60ad51fc8630#diff-8ac6e866fe880e4fc0f7fea15c62aa1dR164

dantleech commented 10 years ago

Fixed in master

dbu commented 10 years ago

@dantleech once this is green and merged: do you check if all is well for RoutingAuto / RoutingAutoBundle and tag the 1.0.0 version?

dantleech commented 10 years ago

With great pleasure :) Will do so tonight or tomorrow.

dbu commented 10 years ago

With great pleasure :) Will do so tonight or tomorrow.

i think this is what missing from releasing all cmf. if you would find some time during the day, that would be great ;-)