symfony-cmf / routing-auto

RoutingAuto component
https://cmf.symfony.com
Other
6 stars 11 forks source link

Added token provider for Symfony DI Container parameters #17

Closed dantleech closed 9 years ago

dantleech commented 10 years ago

Token provider which provides values from Symfony DI container.parameters.

Should we also support providing values from services?

stdClass:
    uri_schema: {base_path}/sub/path
    token_providers:
        base_path: [ container, [ parameter: "my.bundle.some.parameter" ]
lsmith77 commented 10 years ago

there seems to be a BC break in 2.6 https://travis-ci.org/symfony-cmf/RoutingAuto/jobs/38961769

/cc @stof

wouterj commented 10 years ago

This is for 1.1, isn't it?

dantleech commented 10 years ago

@WouterJ yep

lsmith77 commented 9 years ago

ping

dantleech commented 9 years ago

Do we agree this is a good idea?

I would further add a "service" key in addition to "parameter" and make the two mutually exclusive.

dbu commented 9 years ago

i guess that makes sense. i am not exactly following, lets just keep this at a sane level of complexity and then offer an event or callback or something for when the expression language reaches its limits.

dantleech commented 9 years ago

Updated, reduced the scope to only providing parameters. Services are a bit more involved and would require different configuration.

@WouterJ good with you?

wouterj commented 9 years ago

:+1:

we should not forget to update the bundle.