Closed wouterj closed 9 years ago
I wonder if this is the best way to solve this issue. There are only 2 "method" classes, would it make more sense to abstract the common functionality?
@dantleech that's what I was thinking too. I'll split the second commit into another PR, so we can focus on HHVM compatibility on this PR (which, btw, is now ready)
feel free to also remove the allowed failure on HHVM too as part of this PR
I cherry-picked your first commit into master already and removed the allowed failure
into master and 1.0 btw
@dantleech I've moved all common functionality for content method providers to an abstract class now.
Test failing: Declaration of Symfony\Cmf\Component\RoutingAuto\TokenProvider\ContentMethodProvider::normalizeValue() ...
Why merging into 1.0?
ping @WouterJ
Closing in favor of #33
It turns out this wasn't a prophecy issue...