Closed dantleech closed 9 years ago
This is a huge BC break. As stable isn't released long ago, I think it's acceptable, but it should be noted in the CHANGELOG.
hmm yeah .. kinda big BC break .. but I can live with it at this point.
Although it is a BC break, bear in mind also that currently it is not possible to use adapters other than the PHPCR-ODM adapter in the bundle, so that reduces the impact scope.
@WouterJ can you review and merge?
Also, I dropped the BaseTestCase in this PR and switched to PHPUnit 4.5 and native prophecy support.
You still have to document the BC break in the changelog and prefix it with [BC BREAK]
Updated. There just rests the question about phpunit.
i think many projects use it in require-dev. if it helps having better and easier tests with prophecy, i am ok with keeping it in composer.json
I think perhaps the BC changes here are not necessary as it turns out I can better achieve what I need with a token provider.
SuluCMF requires that the locales are not specified in the "URI" (they are just assumed to be there).
This PR passes the
UriContext
object instead of the URI which gives the Adapter the information it needs in order to correctly handle localization.This will probably be a WIP for a while.