search

symfony-cmf / routing-auto

RoutingAuto component
https://cmf.symfony.com
Other
6 stars 11 forks source link

Changes to support the Sulu routing system #32

Closed dantleech closed 9 years ago

dantleech commented 9 years ago

SuluCMF requires that the locales are not specified in the "URI" (they are just assumed to be there).

This PR passes the UriContext object instead of the URI which gives the Adapter the information it needs in order to correctly handle localization.

This will probably be a WIP for a while.

wouterj commented 9 years ago

This is a huge BC break. As stable isn't released long ago, I think it's acceptable, but it should be noted in the CHANGELOG.

lsmith77 commented 9 years ago

hmm yeah .. kinda big BC break .. but I can live with it at this point.

dantleech commented 9 years ago

Although it is a BC break, bear in mind also that currently it is not possible to use adapters other than the PHPCR-ODM adapter in the bundle, so that reduces the impact scope.

dantleech commented 9 years ago

@WouterJ can you review and merge?

dantleech commented 9 years ago

Also, I dropped the BaseTestCase in this PR and switched to PHPUnit 4.5 and native prophecy support.

wouterj commented 9 years ago

You still have to document the BC break in the changelog and prefix it with [BC BREAK]

dantleech commented 9 years ago

Updated. There just rests the question about phpunit.

dbu commented 9 years ago

i think many projects use it in require-dev. if it helps having better and easier tests with prophecy, i am ok with keeping it in composer.json

dantleech commented 9 years ago

I think perhaps the BC changes here are not necessary as it turns out I can better achieve what I need with a token provider.