search

symfony-cmf / routing-auto

RoutingAuto component
https://cmf.symfony.com
Other
6 stars 11 forks source link

API renamings for 2.0 #44

Closed dantleech closed 7 years ago

dantleech commented 9 years ago

AutoRouteTag

We currently use a getAutoRouteTag method to determine the locale of a route. The idea originally was that this was a more generic name, but now I don't really see the point in this as it is in-fact the locale.

SubjectObject

The term subjectObject is used in the UriContext, the object suffix seems to be unnecessary and could be removed.

dbu commented 9 years ago

if that is what it is, lets do it

wouterj commented 9 years ago

I don't think it's worth breaking BC for this (nor having methods that do not exists in the interface). Let's skip for 2.0, ok?

dantleech commented 9 years ago

Well, its obviously wrong, but we can batch it in when we have a better excuse for a BC break.

dantleech commented 9 years ago

So yeah, fine with me.

dbu commented 7 years ago

@dantleech want to do this before we release 2.0?

wouterj commented 7 years ago

Done in #82