search

symfony-cmf / routing-auto

RoutingAuto component
https://cmf.symfony.com
Other
6 stars 11 forks source link

Move SymfonyContainerParameterProvider to the bundle? #52

Closed wouterj closed 7 years ago

wouterj commented 9 years ago

As the Bundle provides Symfony integration, I think it makes more sense to move the class to the bundle.

/cc @dantleech

dantleech commented 9 years ago

Well, you could be using the DI container standalone, in which case* I think* installing the bundle would feel a bit awkward. IMO the same argument applies inversely to the PHPCR-ODM adapter and Listener. I would rather move those here and so have all of the logic in this component - its just a case of refactoring the tests.

We could also maybe namespace the vendor specific code.

dbu commented 8 years ago

so far we put symfony integrations into the bundles. it does not hurt to have a bundle in your vendors even if you don't use full stack symfony. using the container without full stack seems quite an edge case to me...

was this class never in a tagged release? otherwise this would be a 2.0 discussion...

this is the last blocker for the next release, it seems.

wouterj commented 8 years ago

No, this class has not yet been included in a stable release. Lets move it to the bundle, shall we?

dantleech commented 8 years ago

+1

dbu commented 8 years ago

+1

dbu commented 7 years ago

fixed in #74