search

symfony-cmf / routing-auto

RoutingAuto component
https://cmf.symfony.com
Other
6 stars 11 forks source link

Removed deprecated methods #82

Closed wouterj closed 7 years ago

wouterj commented 7 years ago

fix #79, #81, #44

The method renamings from #44 were applied immediately. We might want to release 1.1.1 that triggers deprecations for these? (focus point for the RC phase)

wouterj commented 7 years ago

@dbu @ElectricMaxxx please give you opinion on:

The method renamings from #44 were applied immediately. We might want to release 1.1.1 that triggers deprecations for these? (focus point for the RC phase)

ElectricMaxxx commented 7 years ago

@wouterj you whant to release 1.1.1 where you mark the methods as deprecated, which you remove here for 2.0? If that is the plan, i think it is valid.

wouterj commented 7 years ago

@ElectricMaxxx yes, indeed. It's not fully according to what we've done in other bundles, but otherwise we'll have to wait with the method renamings till 3.0, which seems a long way...

dbu commented 7 years ago

+1 for the changes. with the 1.1.1 version i dont mind. i assume the number of people using those methods is not huge, so we can do without imho