search

symfony-cmf / routing-auto

RoutingAuto component
https://cmf.symfony.com
Other
6 stars 11 forks source link

Enable the new version of jms/metadata #98

Closed hason closed 7 years ago

dbu commented 7 years ago

jms metadata was known to break BC in minor versions in the past, which is why we restricted to just one minor version. the tests seem to indicate that this works. did you test with the latest version and it works for you?

before we merge, we should also check if routing-auto-bundle works with the new version.

dantleech commented 7 years ago

this is the diff between 1.5.0 and 1.6.0 (latest tag): https://github.com/schmittjoh/metadata/compare/1.5.0...1.6.0

I can't really see any breaking changes there?

dbu commented 7 years ago

indeed, that looks safe enough!