Closed acrobat closed 4 years ago
acrobat
commented
4 years ago @dbu I've required the needed dev testing packages but I also needed a fix in the testing package, see symfony-cmf/testing#202.
I've temporarily required my fork, but due to github's ratelimiting the build currently fails. ~I will restart it in an hour or so.~ Most of the builds are passing now, so still have an error but I think we should look at those when the PR in the testing package is merged
dbu
commented
4 years ago now it installs again \o/
some symfony project setup seems to be missing now for the functional tests. (i think there has been quite some cleanup in symfony-cmf/testing because it was doing too much, and this bundle has not been updated accordingly)
acrobat
commented
4 years ago yes indeed, I was looking into the failures but I didn't understand why it would fail after my changes. But I will check what the cleanup was and what is missing here!
acrobat
commented
4 years ago @dbu It was actually a stupid mistake from my side with the fixes on the testing package.. The build should pass again when symfony-cmf/Testing#203 is merged!
dbu
commented
4 years ago i restarted the build
acrobat
commented
4 years ago Thanks @dbu, looks like everything is green now!
dbu
commented
4 years ago hooray! thanks a ton! i will do the tagging now
alexander-schranz
commented
4 years ago @acrobat @dbu Thats great News 🎉 🎂 . Also a big thanks from the whole @sulu team to both of you 👍
@dbu I did some changes to make (part of) the build pass. Same changes like we did for the routing component.
Only the functional tests still fail, but I don't know what we should do. Are these missing dependencies from he testing package or should we add them here as dev dependencies?