RedirectableUrlMatcher - Githubissues

symfony-cmf / routing-bundle

Symfony bundle to provide the CMF chain router to handle multiple routers, and the dynamic router to load routes from a database or other sources.

160 stars 78 forks source link

RedirectableUrlMatcher #465

Closed johndodev closed 3 years ago

johndodev commented 3 years ago

Q	A
Branch?	"master"
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets	https://github.com/symfony-cmf/routing-bundle/issues/464
	https://github.com/symfony-cmf/Routing/issues/247
License	MIT
Doc PR

At this moment, it will not give the choice to use it or not. We could add a config entry, but

Symfony do not give the choice either,
I like it "keep it simple".

Also, there is no doc yet.

dbu commented 3 years ago

oh, and not to forget: thanks a lot for having taken the time to look into this, much appreciated!

dbu commented 3 years ago

looking at the tests output, once the configuration is at the right place you need to adjust ConfigurationTest as well.

johndodev commented 3 years ago

I have trouble launching tests, php vendor/symfony-cmf/testing/bin/console (from routing bundle root) is throwing that :

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:

  The service "form.choice_list_factory.property_access" has a dependency on a non-existent service "property_accessor".

Requiring the property-access component change nothing (is was already there), any clue ?

dbu commented 3 years ago

sorry for the long silence. i just fixed the build of this bundle in master. can you rebase on master and update your dependencies to see if tests run again?

dbu commented 3 years ago

@johndodev can you find time to rebase this on the master branch to get the build running through again?

johndodev commented 3 years ago

I'm in vacation I will try next week.

johndodev commented 3 years ago

Hello, test bug is gone.

unit tests are passing (I fixed ConfigurationTest by adding "redirectable_url_matcher" entry)
However, when I launch functionnal tests, I have a "could not find driver" Exception, and as the testing documentation has vanished, I dont know what to do at this point.

johndodev commented 3 years ago

I added a unit test for the RedirectableRequestMatcher. Since it has been a long time, can you tell me again what I should do to moving forward (other tests, documentation, ...) ?

dbu commented 3 years ago

the test failure also happens with the master branch now, i can't see it is related to your changes, so i will merge.

if you can still do the doc PR, that would be nice.