Closed johndodev closed 3 years ago
oh, and not to forget: thanks a lot for having taken the time to look into this, much appreciated!
looking at the tests output, once the configuration is at the right place you need to adjust ConfigurationTest as well.
I have trouble launching tests, php vendor/symfony-cmf/testing/bin/console
(from routing bundle root) is throwing that :
In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
The service "form.choice_list_factory.property_access" has a dependency on a non-existent service "property_accessor".
Requiring the property-access component change nothing (is was already there), any clue ?
sorry for the long silence. i just fixed the build of this bundle in master. can you rebase on master and update your dependencies to see if tests run again?
@johndodev can you find time to rebase this on the master branch to get the build running through again?
I'm in vacation I will try next week.
Hello, test bug is gone.
I added a unit test for the RedirectableRequestMatcher. Since it has been a long time, can you tell me again what I should do to moving forward (other tests, documentation, ...) ?
the test failure also happens with the master branch now, i can't see it is related to your changes, so i will merge.
if you can still do the doc PR, that would be nice.
At this moment, it will not give the choice to use it or not. We could add a config entry, but
Also, there is no doc yet.