search

symfony-cmf / search-bundle

UNMAINTAINED - search Bundle for the Symfony CMF project integrating with LiipSearchBundle
http://cmf.symfony.com/
8 stars 10 forks source link

Test lowest versions #32

Closed wouterj closed 9 years ago

wouterj commented 9 years ago

@dbu @lsmith77 how should we handle this one? CmfRoutingBundle 1.1 (which is the lowest requirement of this bundle) is not tested against lowest versions, 1.4 is the first release that is. Should we (a) bump the requirement of CmfRoutingBundle to 1.4 (while the code itself actually still supports 1.1), (b) backport lowest dep tests to CmfRoutingBundle 1.1 or (c) add a correct requirement for the CmfRouting component in this bundle?

lsmith77 commented 9 years ago

imho we can bump the requirement to 1.4 .. lets keep our lives easy here.

lsmith77 commented 9 years ago

btw I guess this should then also fix:

PHP Fatal error:  Class 'Symfony\Cmf\Component\Routing\DependencyInjection\Compiler\RegisterRoutersPass' not found in /home/travis/build/symfony-cmf/SearchBundle/vendor/symfony-cmf/routing-bundle/Symfony/Cmf/Bundle/RoutingBundle/CmfRoutingBundle.php on line 35