search

symfony-cmf / seo-bundle

A SEO Solution for duplicate contents, page titles, etc.
https://cmf.symfony.com
47 stars 27 forks source link

can't install with Seo sonata bundle 2.0.0 #267

Open asennoussi opened 8 years ago

asennoussi commented 8 years ago

symfony-cmf/seo-bundle 1.1.2 requires sonata-project/seo-bundle 1.1.* -> no matching package found.

ElectricMaxxx commented 8 years ago

Caused by some heavy BC breaks between SonataSeo 1.* and 2.* we still keep that version. I think if would take some time to also use SonataSeo 2.*. You do need that SonataVersion?

wouterj commented 8 years ago

@ElectricMaxxx which BC breaks are you talking about? I don't see much: https://github.com/sonata-project/SonataSeoBundle/compare/1.1.10...2.0.0

ElectricMaxxx commented 8 years ago

I have tried it with 2.0. but something was missing, when instantiating that bundle. Don't remember what. But will invest some Time to find it again.

ElectricMaxxx commented 8 years ago

Mhh ... Indeed the changes are some only. And they seem to be not that dangourous. (Except the one in the suggest part of composer.json :-)

ElectricMaxxx commented 8 years ago

i think we should change on 2.0

Warxcell commented 8 years ago

Anything on this?

ElectricMaxxx commented 8 years ago

I think we won't inteoduce SonataSeo on 1.*. WE will give it a Chance on our way into 2.0

Ping @wouterJ Right?

wouterj commented 8 years ago

Well, again, there is not much changed between 1.x and 2.0. We don't override the classes that changed the typehint and other changes are not included. This means it can easily be included in 1.2.1.

wouterj commented 8 years ago

Please note that master (2.0.0-dev) already support SonataSeoBundle 2.0.