search

symfony-cmf / seo-bundle

A SEO Solution for duplicate contents, page titles, etc.
https://cmf.symfony.com
47 stars 27 forks source link

[WIP] symfony 3 support #291

Closed ElectricMaxxx closed 8 years ago

ElectricMaxxx commented 8 years ago

This PR should enable symfony 3 support.

Todos:

ElectricMaxxx commented 8 years ago

@WouterJ is there a chance to get deeper into the deprication warnings then:

Accessing type "text" by its string name is deprecated since version 2.8 and will be removed in 3.0. Use the fully-qualified type class name "Symfony\Component\Form\Extension\Core\Type\TextType" instead: 44x
    14x in SeoContentAdminExtensionTest::testExtraPropertyEditView from Symfony\Cmf\Bundle\SeoBundle\Tests\WebTest\Admin
    8x in SeoContentAdminExtensionTest::testItemEditView from Symfony\Cmf\Bundle\SeoBundle\Tests\WebTest\Admin
    8x in SeoContentAdminExtensionTest::testItemCreate from Symfony\Cmf\Bundle\SeoBundle\Tests\WebTest\Admin
    6x in SeoMetadataTypeTest::testDataClassCreationForNonPhpcr
    6x in SeoMetadataTypeTest::testDataClassCreationForPhpcr
    2x in SeoContentAdminExtensionTest::testAdminExtensionExists from Symfony\Cmf\Bundle\SeoBundle\Tests\WebTest\Admin

I can't see any issue in seo-bundle in that example.

wouterj commented 8 years ago

You can set the env variable to a regex to match the exception message IIRC. If you check the symfony docs about the phpunit bridge, you can read more info

ElectricMaxxx commented 8 years ago

Thx. I will have a look at it tonight.

wouterj commented 8 years ago

Fixed some more things. Most of the todo items in your PR description relate to SonataAdminBundle. At the moment, this PR won't pass as we can't install a Symfony 3 supporting SonataAdminBundle version (see https://github.com/sonata-project/SonataSeoBundle/issues/122)

ElectricMaxxx commented 8 years ago

@WouterJ Defining the initRuntime() method in the "sonata_doctrine_phpcr_admin" extension is deprecated since version 1.23. Use theneeds_environmentoption to get the Twig_Environment instance in filters, functions, or tests; or explicitly implement Twig_Extension_InitRuntimeInterface if needed (not recommended): 19x this one seems to be ours too, or?

wouterj commented 8 years ago

@ElectricMaxxx no, it's of the SonataDoctrinePhpcrAdmin and fixed in 2.0 (2.8 deps still use the 1.x version).

I've a working version locally, just need to fix somethings in the BurgovKeyValueFormBundle and I'll push.

ElectricMaxxx commented 8 years ago

Shall we do a PR on burgovKeyValue of is something on it's way?

wouterj commented 8 years ago

Once https://github.com/Burgov/KeyValueFormBundle/pull/23 is merged, the tests should pass.

ElectricMaxxx commented 8 years ago

I think they have a parallel and almost equal PR to yours. Will Look for a Link After the current meeting.

ElectricMaxxx commented 8 years ago

@WouterJ see https://github.com/Burgov/KeyValueFormBundle/pull/22

ElectricMaxxx commented 8 years ago

Both PRs on BurgovKeyValue are still open.

wouterj commented 8 years ago

:tada: