search

symfony-cmf / seo-bundle

A SEO Solution for duplicate contents, page titles, etc.
https://cmf.symfony.com
47 stars 27 forks source link

[Sitemap] Provide default last modification date guesser #292

Open wouterj opened 8 years ago

wouterj commented 8 years ago

I think this should be introduced by calling a custom method or the like (maybe PHPCR can give us the last mod date already?).

Or maybe make it more generic by having a getSitemapData() method. This method will return an array with sitemap values, which we will set on the UrlInformation.

ElectricMaxxx commented 8 years ago

@dantleech can you give us some feedback if a node has such information, and maybe how to get it through phpcr-odm?

dbu commented 8 years ago

http://doctrine-orm.readthedocs.io/projects/doctrine-phpcr-odm/en/latest/cookbook/last-modified.html

ElectricMaxxx commented 8 years ago

You whant it on the 1.3, that we still have to release. Or wait for 2.0?

dbu commented 8 years ago

if somebody has time to work on it, it would be nice in 1.3. its no BC break, just an additional guesser.

ElectricMaxxx commented 8 years ago

I think i can do it after my REST Talk next week. Now the waiting for the release makes Sense, that is a sweet new feature.

ElectricMaxxx commented 8 years ago

But one question: That information could also go into the header for caching or the FosHttCacheBundle could use that information, right?

dbu commented 8 years ago

in FOSHttpCache, we have no doctrine integrations. we don't have a guesser architecture there. the problem doing that would be to know which object to use. see also https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/issues/184 for a lot of discussion about content object integration.