Remove sonata admin - Githubissues

symfony-cmf / seo-bundle

A SEO Solution for duplicate contents, page titles, etc.

https://cmf.symfony.com

47 stars 27 forks source link

Remove sonata admin #299

Closed ElectricMaxxx closed 8 years ago

ElectricMaxxx commented 8 years ago

this PR removes all sonata admin dependencies and re-implement them in a kind of cmf sonata admin bridge/integration

things to be merged/green:

[x] CmfSonataAdminIntegrationBridge
[x] Test on sandbox

ElectricMaxxx commented 8 years ago

Seems to be ready to review. the sandbox integration works fine.

dbu commented 8 years ago

is the admin bundle merged? (checkboxes are not marked) and did you update the sandbox? we can already do that before merging this PR, so that we notice if anything is amiss.

dbu commented 8 years ago

and please add an explanation to the changelog

ElectricMaxxx commented 8 years ago

The extracted classes are still merged in the SonataIntegration. Will have a look at the sandbox, but i think she was ok.

ElectricMaxxx commented 8 years ago

@wouterj @dbu you have any idea why my build is failing for specific symfony versions?

ElectricMaxxx commented 8 years ago

So this gonna be green in some seconds, anybody wanna review?