sonata-project/block-bundle requires the configuration of default_block

symfony-cmf / seo-bundle

A SEO Solution for duplicate contents, page titles, etc.

https://cmf.symfony.com

47 stars 27 forks source link

sonata-project/block-bundle requires the configuration of default_block #337

Open ElectricMaxxx opened 6 years ago

ElectricMaxxx commented 6 years ago

For some reason we require sonata-projec/block-bundle the the requirement on sonata-project/seo-bundle. Cause of that the required configuration sonata_block.default_contexts: [cms] must be configured.

So we have got two choices:

add that configuration into our reciepes
remove the requirement on sonata's block-bundle

I have no clue how this could work.

dbu commented 6 years ago

is this maybe a hidden requirement of the sonata-project/seo-bundle? if its not, we should indeed drop the requirement.

ElectricMaxxx commented 6 years ago

I talked on sonata chat. They indroduced it as optionial dependency and it jumps on main dependencies for no reason. So i could, if i have time, move it back on sonata-project/seo-bundle. We should exclude the problematic versions here by adding them to conflicts ins composer.json.

dbu commented 6 years ago

lets do that. i would not add the conflicts section, if they now have tagged a stable version. new installs will use the latest releases anyways.

ElectricMaxxx commented 6 years ago

https://github.com/sonata-project/SonataSeoBundle/pull/221 created.