[WIP] DevKit updates - Githubissues

symfony-cmf / seo-bundle

A SEO Solution for duplicate contents, page titles, etc.

https://cmf.symfony.com

47 stars 27 forks source link

[WIP] DevKit updates #339

Closed ElectricMaxxx closed 7 years ago

ElectricMaxxx commented 7 years ago

This is the first try of an dev-kit created PR.

[x] fix packagist name for seo bundle
[x] be aware of project configuration when creating travis matrix (it is currently coppied from the repo as plain text)
[x] fix error [ERROR] Failed with message: Validation Failed: Field "head" is invalid, for resource "PullRequest"
[ ] discuss about the buttons in README.md
[x] configuration to controll Makefile tasks

ElectricMaxxx commented 7 years ago

I currently have a fork of dev-kit running localy, will push the code on a branch later to compare the result with the code, which generates it.

ElectricMaxxx commented 7 years ago

I silently added codecoverage tests through this PR, any opinions against it?

Seems to be nice from this state. Will have to fix master then by using testing component with its scripts.

ElectricMaxxx commented 7 years ago

I think here is an error in the destination version, we should target 2.0 and merge into master then, right? or shall we build different PR on each version? I think this comes from sonata's default branch.

dbu commented 7 years ago

i would only introduce this on the master branch. afaik with the cmf we do not aim to provide long term support of older versions, because it would be too much effort.

ElectricMaxxx commented 7 years ago

@dbu sure, i think the current config depends on the default branch situation of sonata. I will start with master and we could possibly add 2.1 then if there is a change after we released it.

ElectricMaxxx commented 7 years ago

closed in favor of #340