symfony-cmf / simple-cms-bundle

UNMAINTAINED - A more-than-simple cms based on the cmf components
http://cmf.symfony.com/
49 stars 45 forks source link

[WCM] Use the tab features of SonataAdminBundle 2.3 #131

Closed wouterj closed 8 years ago

wouterj commented 9 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This should also work under SonataAdminBundle <2.3. This'll use both groups (columns) and tabs in the admin panel, improving the UX a lot :)

A screenshot of the result (also using the new tree btw):

cmf-simple-cms-admin

This requires https://github.com/sonata-project/SonataAdminBundle/pull/2615 and https://github.com/symfony-cmf/RoutingBundle/pull/284 to be merged.

wouterj commented 9 years ago

SonataAdminBundle PR is merged

dbu commented 9 years ago

do we need to update the minimum version requirement?

wouterj commented 9 years ago

@dbu that's a difficult question to answer. This PR does support the same sonata versions as before, except that for a good interface, it requires the versions with my sonata PR in it.

Is it a big problem to only be compatible with Sonata admin >2.3 ?

lsmith77 commented 9 years ago

can this be merged now?