search

symfony-cmf / simple-cms-bundle

UNMAINTAINED - A more-than-simple cms based on the cmf components
http://cmf.symfony.com/
49 stars 45 forks source link

Fix route basepaths and CmfRoutingBundle #152

Closed wouterj closed 9 years ago

wouterj commented 9 years ago

Let's fix https://github.com/symfony-cmf/RoutingBundle/issues/290

Prepending isn't the solution here, as it means we override the default value (so enabling CmfRoutingBundle + CmfSimpleCmsBundle means only /cms/simple is configured as route_basepath instead of both /cms/simple and /cms/routes). Using a compiler pass, we can just append it to the route basepaths, exactly what we expect to happen.

Besides that, this PR now relies on the initializers to set up things correctly for the tests. As this was broken before, https://github.com/symfony-cmf/Testing/pull/114 should be merged to make these tests pass.

/cc @dbu

lsmith77 commented 9 years ago

@WouterJ just adjust the composer.json to use the relevant branch on the testing component to make the test pass here and prefix the PR with [WIP] .. then we can see that the tests are passing.

dbu commented 9 years ago

:+1:

wouterj commented 9 years ago

Ready to merge

dbu commented 9 years ago

:+1: