Closed dbu closed 10 years ago
dbu
commented
10 years ago @lsmith77 can you review this one too? the BC stuff works to at least make the sandbox still happy. though as there are some BC issues anyways, i wonder if we can simply drop routing configuration from simple cms completely.
dbu
commented
10 years ago whats missing: update the PR on the docs again, and a small PR on CoreBundle to prepend the right paths.
lsmith77
commented
10 years ago hmm would be easier to review such a PR with a branch of the sandbox that integrates all the changes
dbu
commented
10 years ago there you go https://github.com/symfony-cmf/cmf-sandbox/pull/244
would be great to get some input. i will wrap up tonight and then we can tag the RC
lsmith77
commented
10 years ago PageAdmin needs to be adjusted to the options array
lsmith77
commented
10 years ago how does the multilang support work now?
as soon as I add a locale to the page, it will add the /{_locale} bit to the route? (which is why we do not need the "add locale pattern" option?
dbu
commented
10 years ago either you manually (or maybe in the admin?) set the add_locale_pattern option, or you enable the auto_locale_pattern option on routing bundle. this is however global and will affect all routes, also those from other routes. though it should not affect routes that already have a locale in them, though that might still be incorrect.
dbu
commented
10 years ago symfony 2.5 will probably fail until https://github.com/sonata-project/SonataAdminBundle/pull/2027 is merged.
dbu
commented
10 years ago alright, i updated this and i think its ready now
dbu
commented
10 years ago okay, updated the test, should be good now. 2.5 will still fail as the PR on sonata admin is not merged yet.
lsmith77
commented
10 years ago looks good .. but we probably need to bump the CoreBundle requirement
adjust to https://github.com/symfony-cmf/RoutingBundle/pull/210