search

symfony-cmf / sonata-phpcr-admin-integration-bundle

Symfony CMF sonata PHPCR admin implementations
https://cmf.symfony.com
5 stars 20 forks source link

Make SF4 Installation possible #129

Open ElectricMaxxx opened 6 years ago

ElectricMaxxx commented 6 years ago

Currently the build of SF4 with this bundle breaks because of dependencies, which still do not support SF4 (IvoryCkeditor, ...). We should change that and make the test green.

ElectricMaxxx commented 6 years ago

Major blocker is: CkEditorBundle atm

  - Conclusion: don't install symfony/symfony v4.0.0-BETA2
    - Conclusion: don't install symfony/symfony v4.0.0-BETA1
    - egeloen/ckeditor-bundle 4.0.0 requires symfony/framework-bundle ~2.2|~3.0 -> satisfiable by symfony/framework-bundle[2.2.x-dev, 2.3.x-dev, 2.4.x-dev, 2.5.x-dev, 2.6.x-dev, 2.7.x-dev, 2.8.x-dev, 3.0.x-dev, 3.1.x-dev, 3.2.x-dev, 3.3.x-dev, 3.4.x-dev, v2.8.0, v2.8.0-BETA1, v2.8.1, v2.8.10, v2.8.11, v2.8.12, v2.8.13, v2.8.14, v2.8.15, v2.8.16, v2.8.17, v2.8.18, v2.8.19, v2.8.2, v2.8.20, v2.8.21, v2.8.22, v2.8.23, v2.8.24, v2.8.25, v2.8.26, v2.8.27, v2.8.28, v2.8.29, v2.8.3, v2.8.30, v2.8.31, v2.8.32, v2.8.33, v2.8.4, v2.8.5, v2.8.6, v2.8.7, v2.8.8, v2.8.9, v3.3.0, v3.3.0-BETA1, v3.3.0-RC1, v3.3.1, v3.3.10, v3.3.11, v3.3.12, v3.3.13, v3.3.14, v3.3.15, v3.3.2, v3.3.3, v3.3.4, v3.3.5, v3.3.6, v3.3.7, v3.3.8, v3.3.9, v3.4.0, v3.4.0-BETA1, v3.4.0-BETA2, v3.4.0-BETA3, v3.4.0-BETA4, v3.4.0-RC1, v3.4.0-RC2, v3.4.1, v3.4.2, v3.4.3], symfony/symfony[2.8.x-dev, 3.3.x-dev, 3.4.x-dev].
torreytsui commented 6 years ago

@ElectricMaxxx

Any progress so far? I suppose we are migrating to FOS ckeditor bundle and want to see if I would be able to help out. I'm new to Symfony though.

ElectricMaxxx commented 6 years ago

@torreytsui no worries, we do have to finish this package here,

ElectricMaxxx commented 6 years ago

i think finishing #135 is the major blocker.

torreytsui commented 6 years ago

@ElectricMaxxx I added a PR to address the travis issue now. Will need your help to set up a travis env var though. https://github.com/symfony-cmf/sonata-phpcr-admin-integration-bundle/pull/138

Amunak commented 6 years ago

Um, what's this (or #135) waiting for? Currently the CMF seems to not really be usable on Symfony 4 despite claiming to be compatible.

ElectricMaxxx commented 6 years ago

@Amunak you still have more issues except this bundle? From my POV all others are released and SF-4 ready, isn't it? If nt it would be nice to get some feedback in issues.

Amunak commented 6 years ago

@ElectricMaxxx I'm not entirely sure how to integrate Sonata with CMF. I managed to install CMF (using Flex recipe for symfony-cmf/cmf-phpcr-dbal-pack) with RoutingAutoBundle, and with some small hiccups it seems to work as far as I can tell.

However, apart from the Sonata Admin Bundle integration I've had a major issue with documentation - there are links to variously outdated stuff all over the place; the fact that there are Flex recipes isn't even mentioned, and there is a "tutorial" but it's not very clear where it starts and how to follow it when you want to go with the recipes and such and not use the CMF Sandbox.

Oh and sorry if this is the wrong place to discuss this, but if you want feedback... x)

Some more specific stuff that doesn't work: the recipe was originally broken, there was a typo, I managed to fix that upstream already. There is also an issue finding templates for the BlockBundle (though that may be on Sonata; you get a Unable to find template "CmfBlockBundle:Block:block_base.html.twig" error). Also - there is no default template for the default ViewController, which means that you get a Unable to find template "" error. I'd suggest putting a template with the slug name there or something, or mentioning how to set it up in the RoutingAutoBundle doc.

ElectricMaxxx commented 6 years ago

@Amunak thanks for that feedback. And yes i really like to get that feedback. Instead of shouting in sillence, i would like to get a new ticket here in GitHub. At the end it does not matter where, because sometimes it depends several packages.

To your specific problems:

Can you open an issue in the pack repository pls, generating typos is exactly my skill.

Sonata Integration: In general it works for 1.* Of this repo. And indeed it is the last missing part in the whole cmf ecosphere. And indeed i asked for Support several times on Twitter, cause the CMF contains more then 10 maintained repositories. So some more hands and ideas would be great at all. When having this package ready, i would work on docs, if you find some better words feel free to open a PR. Our sonata packahe inside SonataProject Organization, should be merged next days, so we are on finish line.

Amunak commented 6 years ago

Can you open an issue in the pack repository pls, generating typos is exactly my skill.

Good news, it has already been fixed and merged :) (it's in the PR)

Our sonata packahe inside SonataProject Organization, should be merged next days, so we are on finish line.

Good to hear it's being worked on, it's the last missing piece of the puzzle. Thank you for your work.

I'll make sure to contribute if I find a decent way; currently I'm still slightly struggling with the configuration and such, so when I grasp it I can think of helping others as well.