search

symfony-cmf / sonata-phpcr-admin-integration-bundle

Symfony CMF sonata PHPCR admin implementations
https://cmf.symfony.com
5 stars 20 forks source link

Integrated the RoutingBundle admins #13

Closed wouterj closed 7 years ago

ElectricMaxxx commented 8 years ago

Looks nice.

Any chance to activate the extensions and test that?

Can we test the existence of the new parameters and services in the ExtensionTest?

wouterj commented 8 years ago

I don't really like the unit tests of extensions and DI stuff. They contain lot's of assertions that'll change each time you edit something in a DI class.

The web tests already test all admins, so also their configuration.

ElectricMaxxx commented 8 years ago

mh indeet, that is a good point. I saw them as an easy way of writing tests to see if the extension is working well.

Now i saw the AdminExtension test.

Ok, Code looks good. Can we do something for the tests here? Shall we support Symfony 3.2 in here when sonata does not support it?

wouterj commented 8 years ago

Ok, Code looks good. Can we do something for the tests here? Shall we support Symfony 3.2 in here when sonata does not support it?

Nope, not that much. It's just waiting for Sonata atm. And yes, of course we should support 3.2 😸

ElectricMaxxx commented 8 years ago

then this PR LGTM.