search

symfony-cmf / sonata-phpcr-admin-integration-bundle

Symfony CMF sonata PHPCR admin implementations
https://cmf.symfony.com
5 stars 20 forks source link

Remove deprecations on SF 3.4 builds #130

Open ElectricMaxxx opened 6 years ago

ElectricMaxxx commented 6 years ago

There are still some deprecation warnings for removed features in SF4. Those should be removed/fixed before being SF4 compatible.

ElectricMaxxx commented 6 years ago 
The Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\FormPass class is deprecated since Symfony 3.3 and will be removed in 4.0. Use Symfony\Component\Form\DependencyInjection\FormPass instead: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Relying on the form mapping feature is deprecated since 3.7 and will be removed in 4.0. Please set the "sonata_core.form.mapping.enabled" configuration node to false to avoid this message: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Using service id sonata.seo.block.breadcrumb.homepage different from block id homepage is deprecated since 3.3 and will be removed in 4.0: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Using service id cmf.block.action different from block id request_stack is deprecated since 3.3 and will be removed in 4.0: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Using service id cmf.block.menu different from block id cmf.block.reference is deprecated since 3.3 and will be removed in 4.0: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Using the "request" attribute of the "knp_menu.voter" tag is deprecated since version 2.2. Inject the RequestStack in the voter instead: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
The Knp\Bundle\MenuBundle\EventListener\VoterInitializerListener class is deprecated since 2.2 and will be removed in 3.0: 1x
    1x in ActionBlockAdminTest::testBlockList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
ElectricMaxxx commented 6 years ago 

The "sonata.admin.doctrine_phpcr_form.filter.type.choice" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 10x
    1x in ActionBlockAdminTest::testBlockList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
    1x in ContainerBlockAdminTest::testBlockList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
    1x in MenuBlockAdminTest::testBlockList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
    1x in ReferenceBlockAdminTest::testBlockList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
    1x in SimpleBlockAdminTest::testBlockList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
    1x in StringBlockAdminTest::testBlockList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
    1x in StaticContentAdminTest::testContentList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
    1x in RedirectRouteAdminTest::testRedirectRouteList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Routing
    1x in RouteAdminTest::testRouteList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Routing
    1x in SeoContentAdminExtensionTest::testAdminExtensionExists from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Seo\Extension
The "doctrine_phpcr.odm.document_manager" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 7x
    5x in MenuAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Menu
    1x in MenuAdminTest::testMenuDelete from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Menu
    1x in MenuNodeAdminTest::testDelete from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Menu
The "sonata.admin.doctrine_phpcr.form.collection_type_extension" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 6x
    3x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    2x in StaticContentAdminTest::testContentCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
    1x in StaticContentAdminTest::testContentEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
The "sonata.admin.doctrine_phpcr.form.collection_type_extension" service is private, checking for its existence is deprecated since Symfony 3.2 and will fail in 4.0: 6x
    3x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    2x in StaticContentAdminTest::testContentCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
    1x in StaticContentAdminTest::testContentEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
The "sonata.core.form.type.collection" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 6x
    3x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    2x in StaticContentAdminTest::testContentCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
    1x in StaticContentAdminTest::testContentEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
The "assets.packages" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 4x
    2x in StaticContentAdminTest::testContentEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
    2x in StaticContentAdminTest::testContentCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
The "cmf_routing.route_type_form_type" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 3x
    2x in RouteAdminTest::testRouteCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Routing
    1x in RouteAdminTest::testRouteEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Routing
The "sonata.core.form.type.array" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 3x
    2x in RouteAdminTest::testRouteCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Routing
    1x in RouteAdminTest::testRouteEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Routing
The "ivory_ck_editor.form.type" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 3x
    2x in StaticContentAdminTest::testContentCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
    1x in StaticContentAdminTest::testContentEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin
The "burgov_key_value_form.key_value_type" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 2x
    1x in SeoContentAdminExtensionTest::testItemEditView from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Seo\Extension
    1x in SeoContentAdminExtensionTest::testItemCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Seo\Extension
The "cmf_seo.form.type.seo_metadata" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 2x
    1x in SeoContentAdminExtensionTest::testItemEditView from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Seo\Extension
    1x in SeoContentAdminExtensionTest::testItemCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Seo\Extension
The "burgov_key_value_form.key_value_row_type" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 2x
    1x in SeoContentAdminExtensionTest::testItemEditView from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Seo\Extension
    1x in SeoContentAdminExtensionTest::testItemCreate from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Seo\Extension
The Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\FormPass class is deprecated since Symfony 3.3 and will be removed in 4.0. Use Symfony\Component\Form\DependencyInjection\FormPass instead: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
The Knp\Bundle\MenuBundle\EventListener\VoterInitializerListener class is deprecated since 2.2 and will be removed in 3.0: 1x
    1x in ActionBlockAdminTest::testBlockList from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Using the "request" attribute of the "knp_menu.voter" tag is deprecated since version 2.2. Inject the RequestStack in the voter instead: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
The "sonata.admin.doctrine_phpcr.form.type.phpcr_odm_tree_manager" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 1x
    1x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Menu
The "sonata.admin.doctrine_phpcr.tree_controller" service is private, checking for its existence is deprecated since Symfony 3.2 and will fail in 4.0: 1x
    1x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Menu
The "sonata.admin.doctrine_phpcr.tree_controller" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 1x
    1x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Menu
The "sonata.admin.doctrine_phpcr.form.type.choice_field_mask" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead: 1x
    1x in MenuNodeAdminTest::testEdit from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Menu
Using service id cmf.block.menu different from block id cmf.block.reference is deprecated since 3.3 and will be removed in 4.0: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Using service id cmf.block.action different from block id request_stack is deprecated since 3.3 and will be removed in 4.0: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Using service id sonata.seo.block.breadcrumb.homepage different from block id homepage is deprecated since 3.3 and will be removed in 4.0: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Relying on the form mapping feature is deprecated since 3.7 and will be removed in 4.0. Please set the "sonata_core.form.mapping.enabled" configuration node to false to avoid this message: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
Not setting "logout_on_user_change" to true on firewall "main" is deprecated as of 3.4, it will always be true in 4.0: 1x
    1x in ActionBlockAdminTest::setUp from Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\WebTest\Admin\Block
ElectricMaxxx commented 6 years ago

FormPass can not solve this one as it lives in sonata and will be fixed/removed in Sonata 4.0

dbu commented 6 years ago

see #132 - i think we should not care about deprecations in the vendors.

ElectricMaxxx commented 6 years ago

yea, but when that means, we would have a broken release for SF4, we do have to wait or fix it in the vendor.

dbu commented 6 years ago

if we build with SF4 we see that its broken. and if we don't we can't claim to support it. i think having this is a step to see whats actually happening in this package itself. once all issues in here are solved, we can switch back to 0 and see about the vendors.

ElectricMaxxx commented 6 years ago

OK, working with errors is easier then trying to find and remove deprecations.