search

symfony-cmf / sonata-phpcr-admin-integration-bundle

Symfony CMF sonata PHPCR admin implementations
https://cmf.symfony.com
5 stars 20 forks source link

Integration of CoreBundle #17

Closed ElectricMaxxx closed 7 years ago

ElectricMaxxx commented 7 years ago

Todo:

ElectricMaxxx commented 7 years ago

@wouterj you didn't have those breaking build for php 7.0 and symfony 3.0 (deprecations) on routing and core, right?

ElectricMaxxx commented 7 years ago

i think the failing build is a phpunit or phpunit-bridge problem. The failing one calls a new composer update with a version change -> dev-master came into the field. it seems that a different phpunit version is the trigger for that behavior. I have 5.3.5 for the failing one and 4.8.30 of the green ones.

ElectricMaxxx commented 7 years ago

It can not be the phpunit version as i have the same that fails on green one too. The phpunit version seems to correlate to the php version. But for some reasons the simple-phpunit scripts seems to change the dependencies befor testing on the failing build. I think the reason is: i get dev-master of phpunit-bridge instead of 3.2.

@wouterj you know why?

ElectricMaxxx commented 7 years ago

Got it. Thanks to @wouterj He describes, that the major point is the amount of deprecation warning. So using weak for the broken test solves my problem.

ElectricMaxxx commented 7 years ago

@symfony-cmf/contributors ready to review, please.

ElectricMaxxx commented 7 years ago

@wouterj ok for you too? (still got a declined review from you side)

ElectricMaxxx commented 7 years ago

the removement is merged, so lets do it here too.