Integrate sonata admin classes and configuration

symfony-cmf / sonata-phpcr-admin-integration-bundle

Symfony CMF sonata PHPCR admin implementations

https://cmf.symfony.com

5 stars 20 forks source link

Integrate sonata admin classes and configuration #23

Closed ElectricMaxxx closed 7 years ago

ElectricMaxxx commented 7 years ago

fix https://github.com/symfony-cmf/block-bundle/issues/257

ToDo:

[x] Add Admin classes
[x] Add configuration
[x] Add Configuration tests
[x] Add Web tests
[x] Add dependencies
[x] tests green

ElectricMaxxx commented 7 years ago

I currently use the way of passing classes as configured parameters into the services as it was done in the block-bundle, but i don't think that this is usall atm.

What to do now?

use defaultNull() and overwrite class-values and arguments for not null?
completely remove the parameters and use FQCN instead - no configuration für classes anymore

ElectricMaxxx commented 7 years ago

uhh, this had been the first time, that i had to merge and use the cleared block-bundle to get stuff working in here. Had problems with the old admin classes. But the testsare green now locally.

ElectricMaxxx commented 7 years ago

@symfony-cmf/contributors ready to review and to discuss about the the class-parameter situation mentioned above.