search

symfony-cmf / sonata-phpcr-admin-integration-bundle

Symfony CMF sonata PHPCR admin implementations
https://cmf.symfony.com
5 stars 20 forks source link

get rid of class parameters #37

Closed dbu closed 7 years ago

dbu commented 7 years ago

fix #34, fix #15

i also did some other cleanups as i stumbled over them.

dbu commented 7 years ago

all php 5.5 builds also fail in master. this seems ready to merge to me.

ElectricMaxxx commented 7 years ago

@dbu i don't think so. My branch (which is your target) is green, but we can fix it there? But i will run mine again, to verify it.

ElectricMaxxx commented 7 years ago

@dbu i missundeststood you arn't pushing against my branch #35 ? can you do so and only do the changes i forgot?

dbu commented 7 years ago

i missundeststood you arn't pushing against my branch #35 ? can you do so and only do the changes i forgot?

ah damn, did not notice you started this as well :-|. you should have assigned the issue to you, maybe then i would have seen you already work on it. closing this and rebased on your branch, lets see

ElectricMaxxx commented 7 years ago

ah, sorry, normally i assign every issue/pr forget this one.