Use Sonata admin tabs - Githubissues

symfony-cmf / sonata-phpcr-admin-integration-bundle

Symfony CMF sonata PHPCR admin implementations

https://cmf.symfony.com

5 stars 20 forks source link

Use Sonata admin tabs #43

Closed wouterj closed 7 years ago

wouterj commented 7 years ago

fix #42, #27, #4

Todo

[x] Use tabs in the block bundle
[x] Translate SeoBundle fields (problems with Form component integration)
[x] Make form_group and form_tab of the extensions configurable

wouterj commented 7 years ago

/ping @dbu @ElectricMaxxx Ready to review & merge imo

wouterj commented 7 years ago

@ElectricMaxxx can you please add me maintainer as maintainer on packagist or enable the packagist service for this repository yourself? If you've done so, using dev-issue-4/use-tabs on your sandbox branch will give you a demo of this PR.

ElectricMaxxx commented 7 years ago

I hope i did both now. So you are maintainer and i hopefully activated the hook.

ElectricMaxxx commented 7 years ago

Menu: auswahl_064

Route: auswahl_063

Content: auswahl_062

My Opinion: Awesome

wouterj commented 7 years ago

Please also note that most extensions now have dedicated tabs on the page. These can be customized in the settings (e.g. one can configure to show the publish workflow stuff on the main tab as well).

ElectricMaxxx commented 7 years ago

@wouterj yes found it. Really nice now. Never thought, that we can combine blocks and tabs :-)

dbu commented 7 years ago

thanks for the clarifications. this looks good to me then. you marked the PR WIP, but i think we can just merge it then and further clean up in separate PRs.

ElectricMaxxx commented 7 years ago

Same from. Me found some missing translations through the debug toolbar in sandbox (there is a branch checked out from my branch with this work inside) But will collect them in a separate issue.

wouterj commented 7 years ago

Merging