search

symfony-cmf / standard-edition

The "Symfony CMF Standard Edition" distribution
cmf.symfony.com
MIT License
118 stars 48 forks source link

Unable to select images with hallo editor #40

Closed umpirsky closed 8 years ago

umpirsky commented 9 years ago

In src/Acme/DemoBundle/Resources/views/layout.html.twig I included hallo editor like:

{% render(controller("cmf_create.jsloader.controller:includeJSFilesAction", {'editor': 'hallo'})) %}

When I try to select image, I get:

selection_004

Did I miss something?

lsmith77 commented 9 years ago

it should work in the sandbox. I think what is missing is the ElFinderBundle. we should probably remove the image button in the SE

umpirsky commented 9 years ago

Some error in such case would be also helpful.

dbu commented 9 years ago

@lsmith77 afaik hallo has nothing to do with elfinder, it has its own image plugin.

the hallo image plugin might be broken. there is a bunch of open issues at the hallo github repository.

the bootstrap code is here: https://github.com/symfony-cmf/CreateBundle/blob/master/Resources/public/js/init-create-hallo.js#L27-L37

and the image information is triggered here https://github.com/symfony-cmf/CreateBundle/blob/master/Resources/views/includejsfiles-create.html.twig#L4-L9

but https://github.com/symfony-cmf/CreateBundle/blob/master/DependencyInjection/Configuration.php#L74 looks like by default, image support is disabled. and the standard edition does not change that.

@umpirsky did you change any configuration? if you can investigate the problem, that would be great! i would suggest to first make sure you have the very latest version of hallo - maybe we just need to update the dependency in this bundle.

umpirsky commented 9 years ago

@dbu I didn't change anything except described, I will try to dig into it when I find some time. Thanks!

dbu commented 9 years ago

thanks! sorry to not be more helpful - i fear the people who did the hallo integration are mostly not active on the project anymore. this is why we switched to ckeditor as default, but its a pitty, hallo is very neat and clean. so any help is appreciated.

umpirsky commented 9 years ago

In deed, yes.

wouterj commented 8 years ago

In https://github.com/symfony-cmf/standard-edition/pull/54, all demo stuff was removed from this episode. If this bug is still related, consider opening it on the CreateBundle repository