search

symfony-cmf / symfony-cmf-docs

The documentation for the symfony content management framework
http://cmf.symfony.com
44 stars 157 forks source link

Fix missing namespace usage #599

Closed vadim2404 closed 10 years ago

dantleech commented 10 years ago

Is this really necessary?

wouterj commented 10 years ago

@dantleech @dbu and @lsmith77 thought so. I'm not sure where we discussed this.

wouterj commented 10 years ago

btw, @lsmith77 , this should have been merged in 1.1.

dantleech commented 10 years ago

@WouterJ I don't remember discussing it :) To me this seems unnecessary for a tutorial, if anything I would add a comment or a note telling the user that they might want to check the type of the document manager.

But -- would this actually every happen? Are not fixtures in the PHPCR directory loaded only by the PHPCR fixture manager?

Why was it necessary to add this?

dbu commented 10 years ago

we did the same in other places. if you point to your fixtures explicitly, and use the wrong fixture command (doctrine:fixtures:load vs doctrine:phpcr:fixtures:load) you will be confused. with this change you should see what is wrong.

the discussion was in #506

dantleech commented 10 years ago

ok thats fine then.