search

symfony-cmf / symfony-cmf-docs

The documentation for the symfony content management framework
http://cmf.symfony.com
44 stars 157 forks source link

Added filelocation in code snippet for bundles\menu #615

Closed Clindbergh closed 10 years ago

Clindbergh commented 10 years ago

fix #604 . Should work with travis.

dbu commented 10 years ago

is this the same as #614? what id the difference?

if you change thing, its easiest if you push to the same branch again, github then updates the pull request. you can --amend and push -f to update the previous commit.

Clindbergh commented 10 years ago

Sorry, couldn't update the commit in 614 and can't do it anymore (since the repo isn't linked anymore). Will update this one with your suggested changes.

The difference is an added line break after the code block, so that the Build passes.

dbu commented 10 years ago

okay. i copied the relevant comments from the other PR so we don't forget about it.

dbu commented 10 years ago

@Clindbergh closing this PR was an automatic action of github because we deleted the dev branch (it was used for preparing the 1.2 release...). can you please create a new pull request against the master branch?

dbu commented 9 years ago

@Clindbergh any chance you could open a new PR with this code? maybe rebase your commit onto the current master?

Clindbergh commented 9 years ago

@dbu Here you go - I missed it.