symfony-cmf / symfony-cmf-docs

The documentation for the symfony content management framework
http://cmf.symfony.com
44 stars 157 forks source link

Add cmf_find_translation twig function documentation #769

Closed EmmanuelVella closed 8 years ago

EmmanuelVella commented 8 years ago

@dbu Related to https://github.com/symfony-cmf/core-bundle/pull/201

dbu commented 8 years ago

sorry, one last thing: we should have a versionadded block after the list of twig functions that says in which version we added this function. otherwise users of an older version will be confused. (for the exact syntax, look for ..versionadded: in the doc sources, we use that in several places)

dbu commented 8 years ago

version would be 1.3.1 of the core bundle

EmmanuelVella commented 8 years ago

No problem, is it ok like this ?

dbu commented 8 years ago

sorry, no the doc should be in the table with the others. the versionadded just explains when this particular function has been added. like "The cmf_find_translation twig function has been added in version 1.3.1 of the CMF CoreBundle."

EmmanuelVella commented 8 years ago

Ho sorry, I just fixed it, hope it's ok now !

dbu commented 8 years ago

yep, that was the idea. thank you!