symfony-cmf / symfony-cmf-docs

The documentation for the symfony content management framework
http://cmf.symfony.com
44 stars 157 forks source link

(DoctrinePHPCRBundle) Document details of mapping options #851

Closed torreytsui closed 5 years ago

torreytsui commented 5 years ago

Since the change in https://github.com/doctrine/DoctrinePHPCRBundle/pull/330, which removes an incorrect hard-coded application level mapping, mappings config becomes necessary in most cases. To offer easier setup, the config usage needs to be documented in more detail. This PR references from doctrine orm bundle to complete the mapping option details.

This PR applies to all maintained versions and therefore it is not necessary to wait until https://github.com/doctrine/DoctrinePHPCRBundle/pull/330 becomes ready and gets merged.

torreytsui commented 5 years ago

Thanks for the feedback! I have updated the PR accordingly now. Please can you have another look?

dbu commented 5 years ago

thanks a lot. i will now merge the 1.3 branch to master to keep that in sync.