Sitemap and Error handling

symfony-cmf / symfony-cmf-website

[website is discontinued] Website for the Symfony CMF

http://cmf.symfony.com

Other

36 stars 29 forks source link

Sitemap and Error handling #94

Closed ElectricMaxxx closed 8 years ago

ElectricMaxxx commented 8 years ago

This PR will add the Sitemap behaviour to the website. A Sitemap link is created in the footer. and will be shown on that. A xml sitemap is also available and can be added to our google analytics acount, that we hopefully have.

Still to do:

[x] add indents to the html sitemap based on the depths in path https://github.com/symfony-cmf/seo-bundle/issues/280
[x] make footer nicer
[x] check and improve error handling
[x] wait until Seo 1.3 is released

ElectricMaxxx commented 8 years ago

@WouterJ styleCI does not like array() notatition. Which PHP version do we use on the website and is styleCI aware of that?

ElectricMaxxx commented 8 years ago

@dbu @wouterj can you give me a hand to update seo-bundle to 1.3 here? Got issues with jms/serializer while updating even with min-stability: dev.

dbu commented 8 years ago

why do you need the minimum-stability? for the cmf dependencies? i notice that no version numbers change in composer.json... is it possible to explicitly require the components and bundles you need with @dev in the version constraint? if that involves too many, you could add a line "prefer-stable": true which should limit what is installed from dev

ElectricMaxxx commented 8 years ago

@dbu whaaaa composer is cheating me. A simple rm -rf vendor/ && composer install && composer require syfmony-cmf/seo-bunde:1.3 and now i have version 1.3.

dbu commented 8 years ago

you still seem to get a server error on travis-ci though

ElectricMaxxx commented 8 years ago

cause my push is now.

dbu commented 8 years ago

does it work locally?

ElectricMaxxx commented 8 years ago

@dbu the failing tests are fine for now, i will fix them and finish that PR here. The problem was, that i hadn't the chance to update the seo-bundle until this morning.

ElectricMaxxx commented 8 years ago

@dbu now i got it almost just one link is broken in the new feature and that behavior is interesting there: On the one hand: yes, the error page looks like it should do :-) On the other hand: I created the footer menu by hand (hardcoded) in the template and have http://127.0.0.1:8000/about/ and got: Shouldn't we be a little bit more calm with that last /?

wouterj commented 8 years ago

Shouldn't we be a little bit more calm with that last /?

It's a setting to allow/disallow trailing slashes (can be set by the admin).

ElectricMaxxx commented 8 years ago

It is fine then. Thanks.

dbu commented 8 years ago

:confetti_ball: