symfony-cmf / tree-browser-bundle

Integrates javascript tree browser with PHPCR and PHPCR-ODM.
https://cmf.symfony.com
Other
22 stars 17 forks source link

Binding to an input with a not loaded child doesn't work #135

Closed wouterj closed 7 years ago

wouterj commented 7 years ago

When rewriting from using key paths to using refKey, we lost the ability to focus not-loaded nodes in the tree using the input. E.g. when the input has /cms/content/home/additionalBlock/child1 and only /cms/content/home is loaded, no node will be focussed.

ElectricMaxxx commented 7 years ago

so that is an handling which happens in the showPath() method, right? That one is called after init.

ElectricMaxxx commented 7 years ago

@wouterj can you give me an example? I can't really reproduce it. I moved one block in sandbox to a deeper position , which was closed, then i reloaded and the node was shown on the deeper position means it was open.

ElectricMaxxx commented 7 years ago

When whatching your concrete example, it works fine if i really understand your issue. So do not open anything here i simply get on the edit view of the child1 block. auswahl_012

wouterj commented 7 years ago

@ElectricMaxxx Trees are loaded with depth 3. So /cms/home/additionalBlock is already loaded. The problem is /cms/home/additionalBlock/child1 is not already loaded. You can see it here: http://sandbox.cmf.symfony.com/en/admin/cmf/block/referenceblock/cms/content/company/additionalInfoBlock/edit (the "Referenced block" form should show the child1 block).

Previously, when asking the tree to focus /cms/home/additionalblock/child1, it would first load /cms/home/additionalBlock, discover the focus not does not yet exist and thus asks for a load of this one's children and focus /cms/home/addititionalBlock/child1.

We should replicate this exact behaviour. It would probably come down to: