search

symfony-cmf / tree-browser-bundle

Integrates javascript tree browser with PHPCR and PHPCR-ODM.
https://cmf.symfony.com
Other
22 stars 17 forks source link

Drag 'n drop no longer works #139

Closed wouterj closed 7 years ago

wouterj commented 7 years ago

https://github.com/symfony-cmf/tree-browser-bundle/pull/136 caused dnd to stop working. We should find a solution for that.

ElectricMaxxx commented 7 years ago

is activate triggered on drag? would be one reason why the complete event chain stops working.

ElectricMaxxx commented 7 years ago

btw: can you give some more information what "stops working" means?

wouterj commented 7 years ago

Selecting a draggable node and dragging it doesn't do anything (node remains at the same location). See the online sandbox. I haven't investigated this in more detail.

Op vr 10 feb. 2017 23:55 schreef Maximilian Berghoff < notifications@github.com>:

btw: can you give some more information what "stops working" means?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/symfony-cmf/tree-browser-bundle/issues/139#issuecomment-279089275, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtt4YO6MYRQBI8FeMbnpXHRE_o2YGBjks5rbOr6gaJpZM4L9r90 .

ElectricMaxxx commented 7 years ago

yea i can see it now too.

uhh that is really tricky. beforeactivation is called on each click. Means on a click to activate and on a click to start dragging. So the event is canceled at all and not dnd will ever start. We need to separate both clicks, but i have no clue how.

ElectricMaxxx commented 7 years ago

The last PR didn't fix the dnd it just makes the non activation in an other way. I think the dnd problem is in #146

ElectricMaxxx commented 7 years ago

fixed through #147