search

symfony-tools / docs-builder

MIT License
28 stars 22 forks source link

Issue with <code> elements in headings #45

Closed javiereguiluz closed 3 years ago

javiereguiluz commented 3 years ago

This file: https://github.com/sonata-project/SonataAdminBundle/blob/3.x/docs/reference/dashboard.rst has things like these:

The ``Admin`` list block
------------------------

Configuring the ``Admin`` list
------------------------------

Using the ``Admin`` service declaration
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

These are wrongly processed in the TOC, which shows the links like this:

image

The contents of the heading are correctly displayed, but the "weird alphanumeric string" leaks to the permalink too:

image

wouterj commented 3 years ago

This is almost identical to https://github.com/doctrine/rst-parser/pull/124 (but that was fixed in another place)

nikophil commented 3 years ago

thanks @wouterj for pointing this out :)

i've provided a fix on the parser https://github.com/doctrine/rst-parser/pull/135

javiereguiluz commented 3 years ago

Closing as fixed. Thanks!