symfony / acl-bundle

Integrates the ACL Security component into Symfony applications.
https://symfony.com/acl-bundle
MIT License
114 stars 40 forks source link

Document schema changes with DoctrineMigrationsBundle #12

Closed cedricziel closed 12 months ago

cedricziel commented 6 years ago

With DoctrineMigrationsBundle, the schema changes will be loaded transparently through a schema listener so that users can apply the schema changes for AclBundle by simply diffing the schema.

cedricziel commented 6 years ago

@xabbuh I updated the PR. I replaced all bash blocks with terminal ones so it's consistent.

cedricziel commented 6 years ago

Anything I could do to make this compliant?

johnpancoast commented 6 years ago

I'm new to this specific project, but I happened to come across this PR and this part about updating with doctrine migrations which seems like an important thing to clarify.

Looking at the above failed build, it seemed it just timed out on a composer update, but I'm not seeing the details on first glance.

Seems as though we should resolve whatever that issue is, merge this PR, and possibly create a 1.0.1 tag with the updated documentation for future users.

Thoughts?

derrabus commented 12 months ago

Thank you @cedricziel.