search

symfony / demo

Symfony Demo Application
https://symfony.com/
MIT License
2.47k stars 1.61k forks source link

Use `#[MapRequestPayload]` for admin blog controller #1435

Closed BafS closed 7 months ago

BafS commented 1 year ago

Fix #1434

Unfortunately there is no Rest endpoints in the demo, I think it would have been more interesting to use it then.

94noni commented 1 year ago

what about on this one? https://github.com/symfony/demo/blob/7e6cc8fa995bb66edc0facacdf89d42bd2b004af/src/Controller/BlogController.php#L155-L159

BafS commented 1 year ago

@94noni I didn't do it because of https://github.com/symfony/demo/issues/1434#issuecomment-1761098715 "Maybe we could do it only in one controller". Unfortunately there is not much to do in any controller. The best would be to introduce a restful api in the demo.

94noni commented 1 year ago

oki got it for the api part, there were already a discuss on that topic

javiereguiluz commented 7 months ago

Closing as "won't merge" for the reasons explained in https://github.com/symfony/demo/issues/1434#issuecomment-1987942195

Sorry!