search

symfony / demo

Symfony Demo Application
https://symfony.com/
MIT License
2.47k stars 1.61k forks source link

Remove Sass from custom CSS files #1450

Closed javiereguiluz closed 11 months ago

javiereguiluz commented 12 months ago

This is mentioned by @weaverryan in #1449.

We don't really use any Sass feature (except nesting and some variables). I've replaced Sass variables by CSS custom properties ... and removed the nesting by flattening all styles (we can readd nesting soon when native support is a big bigger than today: https://caniuse.com/?search=nesting).

Ryan, if you agree on this, can we just merge it and then you rebase your PR? Thanks!

weaverryan commented 12 months ago

Oh, this would make life MUCH easier over on my PR - thank you!

After this, on that PR, we could focus on:

A) importing CSS versions (instead of sass) for all of the vendor packages other than Bootstrap (bootstrap-tagsinput, ~lato-font/scss/public-api, etc). In theory (?) we may be overriding some Sass variables on those. But if we are, we can check on what we're tweaking and find a different solution. B) Keep Bootstrap - but point at the vendor/ directory. Or do you think we could remove the Bootstrap Sass entirely? We're overriding several things in _variables.scss. What I don't know is how feasible it is to make these same changes by overriding CSS properties... especially since the demo uses Bootstrap 4 at the moment (not sure how many CSS properties they use/expose in v4)