Make `Keep me logged in` as a translatable message

symfony / demo

Symfony Demo Application

https://symfony.com/

MIT License

2.46k stars 1.61k forks source link

Make `Keep me logged in` as a translatable message #1498

Closed llupa closed 6 months ago

llupa commented 6 months ago

I used Wikipedia's login page for all messages.

Some notes:

Wikipedia only has pt and this app has pt_BR. Generally Wikipedia's login labels are different from the demo, but I cannot really tell the cultural difference of Keep me logged in
I could not find a way to trigger Wikipedia's sr for latin script, it always defaulted to cyrilic. I used Google's translate API to get the latin version. (It looks ok, but slavic languages are not my forte).
The demo app renders the Japanese text correctly in browser, but over GH it is just a square (test: ロ).

javiereguiluz commented 6 months ago

@llupa thanks a lot for taking the time to extract this new translation. I know this takes some time, so we truly appreciate it 🙇

In #1495 we added a Bengali translation (code bn). The "Keep me logged in" string should be translated as আমাকে প্রবেশকৃত অবস্থায় রাখুন. If you have some time for this, please add that translation too. Otherwise, I'll do it while merging. Thanks a lot!

llupa commented 6 months ago

@javiereguiluz done 👍 but I used GH UI sync button and it did it via merge, not rebase. IDK if you squash when accepting PRs or not. but I can also squash from my side.

Let me know.

javiereguiluz commented 6 months ago

Thanks a lot. Yes, the tool we use to merge things squashes everything by default. If it doesn't work in this case, I'll tell you. Thanks.

gmsantos commented 6 months ago

Wikipedia only has pt and this app has pt_BR. Generally Wikipedia's login labels are different from the demo, but I cannot really tell the cultural difference of Keep me logged in

Native pt-br speaker here. Current translation is fine 👍

javiereguiluz commented 6 months ago

This is now merged! Thanks a lot @llupa