symfony / flex

Composer plugin for Symfony
MIT License
4.17k stars 183 forks source link

fix compatibility with Symfony 7 #1006

Closed shyim closed 10 months ago

shyim commented 10 months ago
PHP Fatal error:  Declaration of Symfony\Flex\Command\RecipesCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /home/runner/work/recipes/recipes/vendor/symfony/flex/src/Command/RecipesCommand.php on line 59
03:09:57 CRITICAL  [php] Fatal Compile Error: Declaration of Symfony\Flex\Command\RecipesCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int ["exception" => Symfony\Component\ErrorHandler\Error\FatalError { …}]
xabbuh commented 10 months ago

Should we do this on the 1.x branch and update the UnpackCommand class at the same time?

fabpot commented 10 months ago

Should we do this on the 1.x branch and update the UnpackCommand class at the same time?

Yes, the 1.x branch is still maintained.

shyim commented 10 months ago

Can we get this merged and released? It's blocking our pipeline 😅

fabpot commented 10 months ago

Done when I merged 1.x into 2.x via #1007

fabpot commented 10 months ago

@shyim Releases done :)

shyim commented 10 months ago

@fabpot the 2.x release seems missing 😅

fabpot commented 10 months ago

@fabpot the 2.x release seems missing 😅

Oops, my bad, should be ok now.