Fixes SYMFONY_REQUIRE environment variable [1.x]

symfony / flex

Composer plugin for Symfony

MIT License

4.15k stars 181 forks source link

Fixes SYMFONY_REQUIRE environment variable [1.x] #948

Closed ncoleshaw-oncorps closed 1 year ago

ncoleshaw-oncorps commented 2 years ago

Closes https://github.com/symfony/flex/issues/946 (1.x)

Backports https://github.com/symfony/flex/pull/947/files to 1.x

maxhelias commented 1 year ago

I didn't see this one before : https://github.com/symfony/flex/pull/947.

This PR should be enough and it will go into 2.x at merge. And some tests would be useful

ncoleshaw-oncorps commented 1 year ago

@maxhelias Thank you for your review. It may be better to close this PR as Flex.php has some differences between 1.x and 2.x that affect the way my proposal is implemented. It may therefore be simpler for this to be a 2.x and later suggestion?

maxhelias commented 1 year ago

I don't know how difficult it is to maintain the 1.x and 2.x branches together so let the Symfony Team decide