search

symfony / flex

Composer plugin for Symfony
MIT License
4.15k stars 181 forks source link

Allow updating recipes without Git project #959

Closed shyim closed 1 year ago

shyim commented 1 year ago

We want to migrate at Shopware our Zip Based Installation users to Composer. For that reason, we are building an own application which updates a project using Composer on shared hosters.

People using Zip files to deploy their stuff are not using Git for their project 🙈 . So I just added the option to use normal Unix patch to patch the files of the changed files instead of expecting a Git repository there.

The Git way is still supported. I just fallback to patch when a git project is not present

stof commented 1 year ago

The git-based workflow relies on git to provide a way to review the changes done by applying the new recipes. How do you plan to do that in a workflow without git ? Reviewing such changes is an important step of the workflow (as changing the configuration of packages in an existing project will have impacts not covered by the BC policy, precisely because you change the config)

shyim commented 1 year ago

Does it maybe make sense to output the list of updated files as a warning? 🤔 So the user should review them?

shyim commented 1 year ago

I will look for an better way maybe and may come back 🙈

stof commented 1 year ago

When using git, git diff gives you exactly that.

shyim commented 1 year ago

I guess I will go the way of recipe:install --force --reset and document that the configs will be resettet when done using web updater 😅

Just merge the old .env of the user with the new one 😅

I guess only non tech people will use that without git anyway 😅